feat(BA-686): Implement Raftify KVS #3838
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyeockJinKim
changed the base branch from
main
to
feat/create-raftify-client
Comment on lines
82
to
84
| """ | ||
| ===================== Leadership and Redirection ===================== | ||
| """ |
There was a problem hiding this comment.
oh i just added it for my personal readability. i'll remove it before the merge
Comment on lines
61
to
68
| apply_res = ApplyResult( | ||
| key=message.key, | ||
| old_value=old_value, | ||
| new_value=new_value, | ||
| revision=self._revision, | ||
| ) | ||
|
|
||
| logger.debug(f"Applied: {apply_res}") |
There was a problem hiding this comment.
Do you need to create an object just for debug logging?
Comment on lines
33
to
40
| class HashStore: | ||
| _store: dict[str, Any] | ||
| _loop: asyncio.AbstractEventLoop | ||
| _revision: int | ||
|
|
||
| def __init__(self) -> None: | ||
| self._store: dict[str, Any] = {} | ||
| self._loop = asyncio.get_running_loop() |
There was a problem hiding this comment.
Remove unused _loop field.
github-actions
bot
added
size:XL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3637 (BA-686)
about
Implements the Raftify KVS which emulates the APIs that
AsyncEtcdoffers. Allows raftify to fully cover the functions that etcd provides.Checklist: (if applicable)
ai.backend.testdocsdirectory