feat(BA-1220): Add redis pubsub broadcaster #4253
Draft
+329
−147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size:L
rapsealk
reviewed
Apr 23, 2025
| except asyncio.CancelledError: | ||
| raise | ||
| except Exception as e: | ||
| log.error("Error while reading broadcasted messages: %s", e) |
There was a problem hiding this comment.
Suggested change
| log.error("Error while reading broadcasted messages: %s", e) | |
| log.error("Error while reading broadcasted messages: {}", e) |
rapsealk
reviewed
Apr 23, 2025
| @@ -126,7 +113,6 @@ async def close(self) -> None: | |||
| self._closed = True | |||
| self._auto_claim_loop_task.cancel() | |||
| self._read_messages_task.cancel() | |||
| self._read_broadcast_messages_task.cancel() | |||
|
|
|||
| async def _auto_claim_loop(self, autoclaim_start_id: str, autoclaim_idle_timeout: int) -> None: | |||
| log.debug("Starting auto claim loop for stream %s", self._stream_key) | |||
There was a problem hiding this comment.
Suggested change
| log.debug("Starting auto claim loop for stream %s", self._stream_key) | |
| log.debug("Starting auto claim loop for stream {}", self._stream_key) |
rapsealk
reviewed
Apr 23, 2025
| @@ -108,7 +95,6 @@ async def close(self) -> None: | |||
| await self._conn.close() | |||
| self._auto_claim_loop_task.cancel() | |||
| self._read_messages_task.cancel() | |||
| self._read_broadcast_messages_task.cancel() | |||
|
|
|||
| async def _auto_claim_loop(self, autoclaim_start_id: str, autoclaim_idle_timeout: int) -> None: | |||
| log.debug("Starting auto claim loop for stream %s", self._stream_key) | |||
There was a problem hiding this comment.
Suggested change
| log.debug("Starting auto claim loop for stream %s", self._stream_key) | |
| log.debug("Starting auto claim loop for stream {}", self._stream_key) |
jopemachine
reviewed
Apr 23, 2025
Comment on lines
+1483
to
+1484
| b = dump_json(raw_event) | ||
| await self._broadcaster.broadcast(b) |
There was a problem hiding this comment.
Suggested change
| b = dump_json(raw_event) | |
| await self._broadcaster.broadcast(b) | |
| await self._broadcaster.broadcast(dump_json(raw_event)) |
Or let's use proper name for b
There was a problem hiding this comment.
It is intended that only one action is performed on a line.
When more than one action is performed, it's hard to see when an issue occurs.
jopemachine
reviewed
Apr 23, 2025
| @@ -539,9 +551,16 @@ async def event_dispatcher_ctx(root_ctx: RootContext) -> AsyncIterator[None]: | |||
| await root_ctx.event_dispatcher.close() | |||
|
|
|||
|
|
|||
| @dataclass | |||
| class EventProcessors: | |||
There was a problem hiding this comment.
Is it correct for the type name to be in plural form?
jopemachine
reviewed
Apr 23, 2025
| broadcaster: AbstractBroadcaster | ||
| subscriber: AbstractBroadcastSubscriber | ||
|
|
||
|
|
||
| def _make_message_queue( |
There was a problem hiding this comment.
I think this function name also should be updated since it does not return message queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4251 (BA-1220)
Checklist: (if applicable)
ai.backend.testdocsdirectory