community[minor]: Taskade Project Loader #5927
Conversation
dosubot
bot
added
the
size:L
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
the
auto:enhancement
![dosubot[bot]](https://avatars.githubusercontent.com/in/324583?s=60&v=4){kind=small}
| @@ -0,0 +1,9 @@ | |||
| import { TaskadeProjectLoader } from "@langchain/community/document_loaders/web/taskade"; | |||
There was a problem hiding this comment.
Hey there! I noticed that this PR adds a new external HTTP request using fetch or axios in the TaskadeProjectLoader. I've flagged this for your review to ensure it aligns with the project's requirements. Let me know if you have any questions!
| @@ -0,0 +1,9 @@ | |||
| import { TaskadeProjectLoader } from "@langchain/community/document_loaders/web/taskade"; | |||
There was a problem hiding this comment.
Hey there! I noticed that the recent change in the taskade.ts file suggests accessing an environment variable for the personalAccessToken. I've flagged this for your review to ensure it aligns with our best practices. Let me know if you have any questions!
| @@ -0,0 +1,13 @@ | |||
| /* eslint-disable no-process-env */ | |||
There was a problem hiding this comment.
Hey there! I noticed that this PR adds a test case that explicitly accesses environment variables via process.env. I've flagged this for your review to ensure proper handling of environment variables. Let me know if you have any questions or need further assistance!
| @@ -0,0 +1,125 @@ | |||
| import { getEnvironmentVariable } from "@langchain/core/utils/env"; | |||
There was a problem hiding this comment.
Hey there! I've reviewed the code changes, and it looks like the TaskadeProjectLoader class introduces a new external HTTP request using the fetch API to fetch project tasks from the Taskade API. I've flagged this change for your review to ensure it aligns with the project's requirements. Let me know if you have any questions or need further clarification!
| @@ -0,0 +1,125 @@ | |||
| import { getEnvironmentVariable } from "@langchain/core/utils/env"; | |||
There was a problem hiding this comment.
Hey team, I've flagged a change in the PR that explicitly accesses an environment variable using the getEnvironmentVariable function. This is to ensure the maintainers review and validate the handling of environment variables in the code.
|
Thanks, @yeouchien—please do check the comments above. Hey everyone, John from Taskade here! We're excited about some upcoming updates related to our multi-agents and use cases. You can catch the latest at https://www.taskade.com/blog/updates/. @hwchase17, we're looking forward to contributing more and figuring out the best ways to make our Custom AI Agents work with https://github.com/langchain-ai/opengpts and offer perhaps enhanced tool compatibility. Open to feedback and suggestions. Thanks again, everyone! |
|
Thank you! LGTM |
|
Amazing thanks Jacob!
…On Wed, Jul 3, 2024 at 4:58 AM Jacob Lee ***@***.***> wrote:
Merged #5927 <#5927> into
main.
—
Reply to this email directly, view it on GitHub
<#5927 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGBMGDGCQMZ47FFZ3H7X4LZKMH7FAVCNFSM6AAAAABKBYATIWVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTGM3TCNZUGQYTSMY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
This PR adds Taskade Project Loader to community document loader.