Skip to content

[5.4] Make migration pre and post status message equal in length #18542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 29, 2017

Conversation

Quezler
Copy link
Contributor

@Quezler Quezler commented Mar 28, 2017

Migrating is of length 9
Migrated is of length 8

I propose to add one space so the names of the actual migrations share the same indentation.
(in other words, make it easier to read over them)

before and after images:

screen shot 2017-03-28 at 16 15 36
screen shot 2017-03-28 at 16 16 13

@Quezler Quezler changed the title Make migration pre and post status message equal in length [5.4] Make migration pre and post status message equal in length Mar 28, 2017
@stefanoruth
Copy link
Contributor

Maybe if then also change the rollback messages too :)

image

@Quezler
Copy link
Contributor Author

Quezler commented Mar 29, 2017

Thanks for the heads up @stefanoruth , i have added it to the pr :) 🎖

@taylorotwell taylorotwell merged commit d96f1ae into laravel:5.4 Mar 29, 2017
Quezler added a commit to Quezler/framework that referenced this pull request Apr 11, 2017
symfony-splitter pushed a commit to illuminate/queue that referenced this pull request Apr 12, 2017
taylorotwell pushed a commit to illuminate/queue that referenced this pull request Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants