[5.1] Force database migration to use the writePdo #18882
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@taylorotwell Thanks for merging this. I'm not familiar with laravel releases workflow. I opened this PR against the 5.1 branch as instructed by the contribution guide, but we are currently using laravel 5.2. Will this fix be cascaded to the subsequent laravel releases, or should I open the same PR against the 5.2 branch? |
PGBI
added a commit
to PGBI/framework
that referenced
this pull request
Apr 21, 2017
taylorotwell
pushed a commit
that referenced
this pull request
Apr 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims at preventing a bug we faced when running migrations before deploying our application on production. We have in our infrastructure a master mysql table and several slaves which replicate master.
Here is what happened:
php artisan migrateon our server => Successphp artisan migrate=> ErrorThe error occurred because Laravel attempted to run the first migration file again.
It turned out one of the slave db had an abnormal replication delay, and was unaware yet of the first migration.
This PR aims at making sure Laravel checks on master and not on a slave which migrations must be run on
php artisan migrate.