[5.5] clone query without order by for aggregates #19022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillkruss
changed the title
|
@taylorotwell if I PR this on the 5.4 branch, can this get merged for a future 5.4.x patch release? |
|
@vetruvet you only mentioned MySQL but I can attest the same fix is necessary for Postgres too. We previously used a local workaround which, thank to your PR, isn't needed anymore 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if there is a global scope that applies an order to the query, it will break counts and other aggregates when MySQL is in strict mode and there is no group-by in place (see issues like 15232, 18789, 14997, etc). This change is to fix that without having to set MySQL to non-strict mode or tell users to change their strict mode flags. It's also a low-impact change - if there are no groupings on the query, then any order is irrelevant anyway so this does not have any side-effects.