Skip to content

[Merged by Bors] - refactor: move the definition of IsRegular earlier #26321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Jun 23, 2025

The motivation here is to be able to define things like IsCancelMulZero in terms of IsRegular, which would allow API for the latter to be used to provide instances for the former.

As a first step, this moves the MulZeroClass lemmas abut IsRegular into the GroupWithZero folder, which is consistent with the ring lemmas living inside the Ring folder.


Open in Gitpod

@eric-wieser eric-wieser requested a review from YaelDillies June 23, 2025 19:12
@github-actions github-actions bot added the t-algebra Algebra (groups, rings, fields, etc) label Jun 23, 2025
Copy link

github-actions bot commented Jun 23, 2025

PR summary f609d6347c

Import changes for modified files

Dependency changes

File Base Count Head Count Change
Mathlib.Algebra.Regular.Basic 214 120 -94 (-43.93%)
Mathlib.Algebra.Ring.Regular 219 135 -84 (-38.36%)
Mathlib.Algebra.Order.Monoid.Unbundled.Basic 208 212 +4 (+1.92%)
Import changes for all files
Files Import difference
There are 4371 files with changed transitive imports taking up over 191168 characters: this is too many to display!
You can run scripts/import_trans_difference.sh all locally to see the whole output.

Declarations diff

+ isLeftRegular
- MulLECancellable.isLeftRegular

You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>

The doc-module for script/declarations_diff.sh contains some details about this script.


No changes to technical debt.

You can run this locally as

./scripts/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@YaelDillies
Copy link
Collaborator

Thanks!

maintainer delegate

Copy link

🚀 Pull request has been placed on the maintainer queue by YaelDillies.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@leanprover-community-mathlib4-bot leanprover-community-mathlib4-bot added ready-to-merge This PR has been sent to bors. and removed maintainer-merge labels Jun 24, 2025
mathlib-bors bot pushed a commit that referenced this pull request Jun 24, 2025
The motivation here is to be able to define things like `IsCancelMulZero` in terms of `IsRegular`, which would allow API for the latter to be used to provide instances for the former.

As a first step, this moves the `MulZeroClass` lemmas abut `IsRegular` into the `GroupWithZero` folder, which is consistent with the ring lemmas living inside the `Ring` folder.
@mathlib-bors
Copy link
Contributor

mathlib-bors bot commented Jun 24, 2025

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors bot changed the title refactor: move the definition of IsRegular earlier [Merged by Bors] - refactor: move the definition of IsRegular earlier Jun 24, 2025
@mathlib-bors mathlib-bors bot closed this Jun 24, 2025
@mathlib-bors mathlib-bors bot deleted the eric-wieser/regular-move branch June 24, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has been sent to bors. t-algebra Algebra (groups, rings, fields, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants