-
Notifications
You must be signed in to change notification settings - Fork 579
[Merged by Bors] - refactor: move the definition of IsRegular
earlier
#26321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR summary f609d6347c
|
File | Base Count | Head Count | Change |
---|---|---|---|
Mathlib.Algebra.Regular.Basic | 214 | 120 | -94 (-43.93%) |
Mathlib.Algebra.Ring.Regular | 219 | 135 | -84 (-38.36%) |
Mathlib.Algebra.Order.Monoid.Unbundled.Basic | 208 | 212 | +4 (+1.92%) |
Import changes for all files
Files | Import difference |
---|---|
There are 4371 files with changed transitive imports taking up over 191168 characters: this is too many to display! | |
You can run scripts/import_trans_difference.sh all locally to see the whole output. |
Declarations diff
+ isLeftRegular
- MulLECancellable.isLeftRegular
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>
The doc-module for script/declarations_diff.sh
contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relative
value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolute
value is therelative
value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
YaelDillies
reviewed
Jun 23, 2025
Thanks! maintainer delegate |
🚀 Pull request has been placed on the maintainer queue by YaelDillies. |
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
The motivation here is to be able to define things like `IsCancelMulZero` in terms of `IsRegular`, which would allow API for the latter to be used to provide instances for the former. As a first step, this moves the `MulZeroClass` lemmas abut `IsRegular` into the `GroupWithZero` folder, which is consistent with the ring lemmas living inside the `Ring` folder.
Pull request successfully merged into master. Build succeeded: |
IsRegular
earlierIsRegular
earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation here is to be able to define things like
IsCancelMulZero
in terms ofIsRegular
, which would allow API for the latter to be used to provide instances for the former.As a first step, this moves the
MulZeroClass
lemmas abutIsRegular
into theGroupWithZero
folder, which is consistent with the ring lemmas living inside theRing
folder.