chore(nightly): update proc-macro span file name method name #3852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @gbj, seems reasonable for the nightly folks |
killshot-karma
pushed a commit
to killshot-karma/leptos
that referenced
this pull request
Apr 18, 2025
NKID00
pushed a commit
to NKID00/leptos
that referenced
this pull request
Apr 24, 2025
sabify
added a commit
to sabify/leptos
that referenced
this pull request
May 2, 2025
sabify
added a commit
to sabify/leptos
that referenced
this pull request
May 2, 2025
gbj
added a commit
that referenced
this pull request
May 4, 2025
* fix(CI): prevent regreession from nightly clippy in autofix * chore: format * chore: update nightly to 2025-04-16 (proc-macro span, #3852) * chore: improve the autofix ci workflow * fix: adjust ServerFn macro test stderr based on nightly-2025-04-16 * fix: limit server_fn server macro trybuild tests nightly only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest nightly
2025-04-15removes the.source_file()method onproc_macro::Span(used in our hot-reloading code) and splits it into.file()andlocal_file().The bad news: this means leptos nightly no longer compiles on latest nightly.
The good news: this is a step toward stabilization for other parts of the API, which is great.
I've made the decision to just change to the newer method name, and require nightly users to use latest nightly.