CA: Run all table test subtests in parallel #7452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given go1.22's change to how loopvars work, this rebinding shouldn't be necessary. These loops should Just Work (tm) and be able to run in parallel anyway. |
|
I would love for that to be the case, but I receive warnings like the one reported here. Edit: This report is more apt golang/go#66876 |
aarongable
previously approved these changes
Apr 24, 2024
aarongable
approved these changes
Apr 24, 2024
beautifulentropy
approved these changes
Apr 25, 2024
vbaranovskiy-plesk
pushed a commit
to plesk/boulder
that referenced
this pull request
May 30, 2024
[Previously](letsencrypt#7438) I had made a change to run all CA tests in parallel, which was great, but I failed to account for several table driven tests. By rebinding the subtest's iterator to the lexical scope, each subtest can now run in parallel.
AlinaADmi
pushed a commit
to plesk/boulder
that referenced
this pull request
Jul 29, 2024
[Previously](letsencrypt#7438) I had made a change to run all CA tests in parallel, which was great, but I failed to account for several table driven tests. By rebinding the subtest's iterator to the lexical scope, each subtest can now run in parallel.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously I had made a change to run all CA tests in parallel, which was great, but I failed to account for several table driven tests. By rebinding the subtest's iterator to the lexical scope, each subtest can now run in parallel.