ra: Add IdentifierTypes to profiles #8154
Merged
+141
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `IdentifierTypes` to validation profiles' config, defaulting to DNS if not set. In `NewOrder`, check that the order's profile permits each identifier's type. Fixes #8137
|
@jprenken, this PR appears to contain configuration and/or SQL schema changes. Please ensure that a corresponding deployment ticket has been filed with the new values. |
aarongable
reviewed
May 14, 2025
aarongable
previously approved these changes
May 15, 2025
aarongable
previously approved these changes
May 15, 2025
beautifulentropy
requested changes
May 16, 2025
beautifulentropy
approved these changes
May 16, 2025
jsha
approved these changes
May 16, 2025
|
Deployment ticket is IN-11341. |
jprenken
added a commit
that referenced
this pull request
May 27, 2025
Permit all valid identifier types in `wfe.NewOrder` and `csr.VerifyCSR`. Permit certs with just IP address identifiers to skip `sa.addIssuedNames`. Check that URI SANs are empty in `csr.VerifyCSR`, which was previously missed. Use a real (Let's Encrypt) IP address range in integration testing, to let challtestsrv satisfy IP address challenges. Fixes #8192 Depends on #8154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
IdentifierTypesto validation profiles' config, defaulting to DNS if not set.In
NewOrder, check that the order's profile permits each identifier's type.Fixes #8137
Depends on #8173