Stop interacting with registration.contact column #8200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarongable
force-pushed
the
remove-contacts-col
branch
from
ccdf68e to
b5d58b7
Compare
aarongable
changed the title
aarongable
force-pushed
the
remove-contacts-col
branch
from
b5d58b7 to
2e7f5f2
Compare
aarongable
changed the title
aarongable
force-pushed
the
remove-contacts-col
branch
2 times, most recently
from
36c1f3e to
3b1eee3
Compare
aarongable
force-pushed
the
remove-contacts-col
branch
from
3b1eee3 to
d864033
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the IgnoreAccountContacts feature flag. This causes the SA to never query the contact column when reading registrations from the database, and to never write a value for the contact column when creating a new registration.
This requires updating or disabling several tests. These tests could be deleted now, but I felt it was more appropriate for them to be fully deleted when their corresponding services (e.g. expiration-mailer) are also deleted.
Fixes #8176
Warning
Do not merge before #8209 has been mergedDo not merge before #8198 has been deployedDo not merge before #8208 has been deployedDo not merge before #8207 has been deployedDo not merge before IN-11354 has been completedDo not merge before IN-11365 has been completed