This repository was archived by the owner on Sep 9, 2022. It is now read-only.
Relay Discovery and unspecific address dialing #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also test full address dialing in transport.
|
summoning @Stebalien @whyrusleeping |
vyzo
changed the title
it's racey, plus relay is a sticky property of nodes; test if we have active connections instead at the time of dial.
This was referenced Jul 24, 2017
Stebalien
reviewed
Jul 25, 2017
| d.mx.Lock() | ||
| for p := range d.relays { | ||
| relays = append(relays, p) | ||
| } |
There was a problem hiding this comment.
FYI, the fast and idiomatic way to do this is:
relays := append([]peer.ID{}, d.relays...)There was a problem hiding this comment.
Nevermind, relays isn't a slice.
|
LGTM. Eventually, we'll probably want to use the DHT to find relays (or maybe even just gossip them) but asking connected peers is a good start. Slightly off topic but it would be nice if peers could advertise us service lists on connect instead of having to test for everything (lots of extra round trips). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements passive relay discovery and unspecific relay address dialing, as discussed in libp2p/go-libp2p#209.
Implementation Notes: