Send IDONTWANT before first publish #612
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
force-pushed
the
marco/IDONTWANT-on-publish
branch
from
f8b4150 to
cf90c94
Compare
raulk
approved these changes
May 9, 2025
| @@ -349,6 +349,7 @@ func (t *Topic) validate(ctx context.Context, data []byte, opts ...PubOpt) (*Mes | |||
| } | |||
|
|
|||
| msg := &Message{m, "", t.p.host.ID(), pub.validatorData, pub.local} | |||
| t.p.rt.PreValidation(t.p.host.ID(), []*Message{msg}) | |||
There was a problem hiding this comment.
While we're working on this area, how about we rename PreValidation() to something more accurate/obvious, e.g. DispatchIDONTWANT() or even something more generic like Preprocess() or Intercept()? The spirit of the method just isn't to validate (returns nothing), and it's confusing when juxtaposed with ValidateLocal() ("what validation happens in each?").
There was a problem hiding this comment.
names, names, names 🤣
But yes, preprocessing is what it does.
There was a problem hiding this comment.
No strong opinion. Preprocess seems fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #610
We previously send IDONTWANT only when forwarding. This has us send IDONTWANT on our initial publish as well. Helps in the case that one or more peers may also publish the same thing at around the same time (see #610 for a longer explanation) and prevents "boomerang" duplicates where a peer sends you back the message you sent before you get a chance to send it to them.
This also serves as a hint to a peer that you are about to send them a certain message.