How do I test autorelay?

[cannium]

In go-ipfs, DHT service is initialized after libp2p, in startOnlineServicesWithHost:

	peerhost, err := hostOption(ctx, n.Identity, n.Peerstore, libp2pOpts...)


	if err != nil {
		return err
	}


	if err := n.startOnlineServicesWithHost(ctx, peerhost, routingOption, pubsub, ipnsps); err != nil {
		return err
	}

(https://github.com/ipfs/go-ipfs/blob/31099e882469fab12a98f2069e38c847f0b1188c/core/core.go#L264-L272)

But the new autorelay feature requires cfg.Routing, which is DHT service:

go-libp2p/config/config.go

Lines 169 to 198 in 4341acb

	if cfg.Routing != nil {
	router, err := cfg.Routing(h)
	if err != nil {
	h.Close()
	return nil, err
	}
	crouter, ok := router.(routing.ContentRouting)
	if ok {
	if cfg.Relay {
	discovery := discovery.NewRoutingDiscovery(crouter)
	hop := false
	for _, opt := range cfg.RelayOpts {
	if opt == circuit.OptHop {
	hop = true
	break
	}
	}
	if hop {
	h = relay.NewRelayHost(swrm.Context(), h.(*bhost.BasicHost), discovery)
	} else {
	h = relay.NewAutoRelayHost(swrm.Context(), h.(*bhost.BasicHost), discovery)
	}
	}
	}
	h = routed.Wrap(h, router)
	}

So we have a dependency loop here(the reason why refactoring is necessary) and I just can't enable the feature. Now I only need a somewhat hacky way to test the feature, I'd like to know what did you do in your tests?

(btw, I had an idea about refactoring, I'll write some snippets to elaborate the idea if interested)

[vyzo]

There is no dependency loop; you pass it a constructor which takes a host, and can then construct the dht from that host.

[vyzo]

Btw, I am working on adding the feature to ipfs, will open pr in the next couple of days.

[cannium]

The only concrete type I could find implements PeerRouting is IpfsDHT, and its initialization requires libp2p Host. Could you fill me more info?

[vyzo]

You have a Host object in the constructor.
So:

libp2p.New(..., libp2p.Routing(func(h host.Host) (routing.PeerRouting, error) {
  // make the DHT with the given Host
  return dht.New(ctx, h, opts...)
}))

[cannium]

Thanks, I'll try again. vyzo <[email protected]> 于 2018年11月19日周一 19:22写道：

…

You have a Host object in the constructor. So: libp2p.New(..., libp2p.Routing(func(h host.Host) (routing.PeerRouting, error) { // make the DHT with the given Host return dht.New(ctx, h, opts...) } — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#487 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABHft-CIx45501Rvut0F8-oNd5FBZ_4Vks5uwpRjgaJpZM4Yo0Ua> .

[vyzo]

For ipfs integration see ipfs/kubo#5785