RoutedHost: NewStream ensures we have the means to connect to the peer #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stebalien
reviewed
Jul 21, 2017
p2p/host/routed/routed.go
Outdated
| } | ||
| rh.Peerstore().AddAddrs(p, addrs, pstore.TempAddrTTL) | ||
| } | ||
|
|
There was a problem hiding this comment.
Is there any reason to not just call Connect? We'll end up calling Connect on the host again from within NewStream but that should be a no-op.
There was a problem hiding this comment.
I think we can safely use connect too, although it's redundant once we've put the addresses in the Peerstore.
Note that BasicHost doesn't call connect explicitly; instead the connection is established by Dial when it sees that it has no active connections.
There was a problem hiding this comment.
it's 5 lines -vs- 3 when using Connect, so I am opting for it; needs a good comment though.
There was a problem hiding this comment.
Updated to use Connect; so yeah, both shorter and easier to understand with the right comment.
whyrusleeping
approved these changes
Jul 23, 2017
vyzo
changed the title
marten-seemann
pushed a commit
that referenced
this pull request
Aug 17, 2022
This drops the opensensus dependency. Nobody uses this, from what I can tell. fixes #58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #207