feat(host): recursively resolve addresses #764
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently only resolve /dnsaddr addresses once. This patch resolves up to 32 dnsaddr addresses per dial. fixes #744
Stebalien
force-pushed
the
feat/recursive-dnsaddr
branch
from
4d27efd to
e5d2869
Compare
vyzo
reviewed
Dec 16, 2019
| resolveSteps, | ||
| maxAddressResolution, | ||
| ) | ||
| continue |
There was a problem hiding this comment.
I want to finish going through the addresses, adding any already resolved addresses. I just don't want to resolve any more.
There was a problem hiding this comment.
ok, fair enough; just concerned about actually terminating the loop.
There was a problem hiding this comment.
There's a test case for that.
(being able to say that is really a nice feeling)
vyzo
approved these changes
Dec 16, 2019
This was referenced Jan 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently only resolve /dnsaddr addresses once. This patch resolves up to 32 dnsaddr addresses per dial.
fixes #744