Skip to content

fix: update append announce addresses #3085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix: update append announce addresses #3085

merged 1 commit into from
Apr 17, 2025

Conversation

achingbrain
Copy link
Member

We allow transports to update announce addresses to add certhashes and other data but updating append announce addresses was missed.

Fixes #3080

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@achingbrain
fix: update append announce addresses
eea5989 
We allow transports to update announce addresses to add certhashes
and other data but updating append announce addresses was missed.

Fixes #3080
@achingbrain achingbrain requested a review from a team as a code owner April 17, 2025 07:11
@achingbrain achingbrain merged commit afa5c9f into main Apr 17, 2025
32 checks passed
@achingbrain achingbrain deleted the fix/update-append-announce-addresses branch April 17, 2025 07:32
@achingbrain achingbrain mentioned this pull request Apr 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Certhash missing from appendAnnounce webrtc-direct multiaddrs
1 participant
@achingbrain