Fix bugs in nmcli wifi driver #17857
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jecaro
commented
May 4, 2025
jecaro
force-pushed
the
fix-nmcli-wifi-driver
branch
from
bde3259 to
5ac5811
Compare
pstef
reviewed
May 5, 2025
| else | ||
| /* This assumes the password doesn't contain single quotes */ | ||
| snprintf(cmd, sizeof(cmd), | ||
| "nmcli dev wifi connect '%s' password '%s'", |
There was a problem hiding this comment.
Single quotes in SSIDs would probably be malicious, but generated passwords will contain those in legitimate cases.
There was a problem hiding this comment.
I haven't tested this, but in principle if you pass "nmcli dev wifi connect $'%s' password $'%s'" then it should be only a matter of replacing each ' with \' in each the SSID and password.
There was a problem hiding this comment.
I agree this is not super robust, and I'm not very happy with it. I'll come up with something better soon.
- Use the password stored in the connection profile instead of asking
each time to the user
- `Disconnect` menu item wasn't shown even when connected
When entering the Wi-Fi menu first, `nmcli_connection_info` is called with
`NULL`. If we return `false` here, the menu doesn't show the `Disconnect`
menu item even when the wifi is on and connected.
- Don't consider wired connections when checking if the device is connected
`cmd_file = popen("nmcli -f NAME c show --active | tail -n+2", "r");`
That command returns all active connections, even the wired ones. That
means that if the wifi is not connected but we have a wired connection,
retroarch shows the Disconnect menu item to disconnect ... a
non-existent wifi connection.
jecaro
force-pushed
the
fix-nmcli-wifi-driver
branch
from
5ac5811 to
3637f49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I'm developing a nixos config for my RPI CM3 handheld.
I've tried using the
nmcliwifi driver for the user to be able to configure his wifi with the builtin gamepad. However, it wasn't usable in this state.A few bugs here and there, and most importantly, the driver was asking for a password each time one connected to a network. That makes the feature useless IMO. As a user, I'd like to be able to configure my wifi network with a password once, turn off the wifi to save battery and only turn it on when I need. But I really don't want to set the password each time I want to use the wifi. It's already cumbersome enough do it once.
Anyway, I dove into the driver and fixed a few things:
Disconnectmenu item wasn't shown even when connected