CMake: Prevent double SDL2 and SDL2main entries in sdl2.pc #9953
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent double imports in pkgconf output.
Description
When building the sdl2.pc for the Playstation Portable, the Libs line looks like this:
That SDL2main and SDL2 are listed double is causing issues for us at the moment.
With this change it will look like this:
For other platforms is seems that this makes no difference for sdl2.pc either.
The CMake files that are generated have access to and use both SDL_LIBS and SDL_STATIC_LIBS variables when built and use both of them. It should not be needed to copy the content of SDL_LIBS into SDL_STATIC_LIBS. I tested on PSP with this change using find_package in CMake and I see no difference. Can someone verify this extra for at least one other platform before merging?
Existing Issue(s)