Query parameter without value is dropped

[PunchyRascal]

If there is a parameter without value, e.g. https://example.com/?foo, then the $uri->query_form() method (but others too) do not return the foo parameter at all.

[oalders]

@PunchyRascal thanks for this. Looks like we should deal with this case. http://stackoverflow.com/questions/4557387/is-a-url-query-parameter-valid-if-it-has-no-value

[PunchyRascal]

I was wondering about the keywords mechanism there, that seems to take over if there is no = sign in the query string, what is its purpose? I understand, that the whole query params thing is very loosely defined outside the HTML form.

[dakkar]

Slightly worse issue:

my $uri = URI->new('http://host/foo?keyword');
$uri->query_form(foo=>'bar');
say $uri;

prints http://host/foo?foo=bar, removing the keyword.

And:

my $uri = URI->new('http://host/foo?foo=bar');
$uri->query_keywords(['keyword']);
say $uri;

prints http://host/foo?keyword, removing the query.

(this breaks a few things downstream, like Paws, see pplu/aws-sdk-perl#105 (comment) )

[oalders]

If someone can put together a patch for this, we can look at getting this taken care of.

[dakkar]

Three proposals! They all change the interface, though ☹ I can't find a way to handle equal-less form params that round-trips and keeps the current interface.

[Grinnz]

FWIW, this is how Mojo::URL handles it:

$ perl -MMojo::URL -E'my $url = Mojo::URL->new(shift); $url->query({foo => "bar"}); say $url->to_string' 'http://host/foo?keyword'
http://host/foo?keyword=&foo=bar

When mixing the formats I think this is the only sensible approach, consider the "keyword" to be a form key without a value (which is valid as 'keyword' or 'keyword=' within the & pairs)

[oalders]

I think following the Mojo pattern makes sense.

[oalders]

URI version would be current behaviour:

perl -Ilib -MURI -E 'my $url = URI->new(shift); $url->query_form(foo => "bar"); say $url->as_string' 'http://host/foo?keyword'
http://host/foo?foo=bar

proposed new behaviour:

perl -Ilib -MURI -E 'my $url = URI->new(shift); $url->query_form(foo => "bar"); say $url->as_string' 'http://host/foo?keyword'
http://host/foo?keyword&foo=bar

[castaway]

#65 looks sane.. what's this waiting on? (Also poking at Paws ;)