feat: add view functions for verify proof of validator and deposit me… #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it message signature
|
Hardhat Unit Tests Coverage SummaryDiff against masterResults for commit: e6a2d55 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Jeday
reviewed
Apr 24, 2025
| @@ -317,7 +339,7 @@ contract PredepositGuarantee is IPredepositGuarantee, CLProofVerifier, PausableU | |||
|
|
|||
| // this check isn't needed in `depositToBeaconChain` because | |||
| // Beacon Chain doesn't enforce the signature checks for existing validators and just top-ups to their balance | |||
| BLS12_381.verifyDepositMessage(_deposit, _depositsY[i], withdrawalCredentials); | |||
| verifyDepositMessage(_deposit, _depositsY[i], withdrawalCredentials); | |||
There was a problem hiding this comment.
Can we check that this extra call does not increase gas cost due to args?
There was a problem hiding this comment.
can quickly compare via tx.gasUsed in some existing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A short summary of the changes.
Context
New Public Functions:
validatePubKeyWCProofto validate a validator's proof against the Beacon block root using withdrawal credentials and a public key. This function wraps the private_validatePubKeyWCProofmethod for external use.verifyDepositMessageto verify the deposit message signature using BLS12-381 pairing checks. This function wraps theBLS12_381.verifyDepositMessagemethod for external use.Refactoring of Existing Calls:
_validatePubKeyWCProofwithvalidatePubKeyWCProoffor proof validation in multiple locations, ensuring consistency and reusability. [1] [2] [3]BLS12_381.verifyDepositMessagewithverifyDepositMessagefor deposit verification, improving code readability and modularity.Problem
What problem this PR solves, link relevant issue if it exists
Solution
Your proposed solution