Remove unnecessary PaymentStatus::SendingFailed
#125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, I had a misunderstood in what event retrying payments is safe. It turns out that it's indeed safe to retry a payment as soon as we receive `LdkEvent::PaymentFailed`. Therefore, we can here now only refuse to send duplicate payments if our previous status is `Succeeded` or `Pending`, which renders the additional distinction between `Failed` and `SendingFailed` superfluous. Accordingly, we remove this `PaymentStatus` variant.
jkczyz
reviewed
Jun 20, 2023
jkczyz
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, I had a misunderstood in what event retrying payments is safe and erred on the conservative side. It turns out that it's indeed safe to retry a payment as soon as we receive
LdkEvent::PaymentFailedand the misleading docs have since been removed (lightningdevkit/rust-lightning#2340).Therefore, we can here now only refuse to send duplicate payments if our previous status is
SucceededorPending, which renders the additional distinction betweenFailedandSendingFailedsuperfluous. Accordingly, we remove thisPaymentStatusvariant.