Add onchain fund recovery test #396
Conversation
tests/integration_tests_rust.rs
Outdated
|
|
||
| let chain_source = TestChainSource::Esplora(&electrsd); | ||
|
|
||
| let seed_bytes: Vec<u8> = std::iter::repeat(42u8).take(64).collect(); |
| @@ -302,6 +304,11 @@ pub(crate) fn setup_node(chain_source: &TestChainSource, config: Config) -> Test | |||
| builder.set_chain_source_bitcoind_rpc(rpc_host, rpc_port, rpc_user, rpc_password); | |||
| }, | |||
| } | |||
|
|
|||
| if let Some(seed) = seed_bytes { | |||
| builder.set_entropy_seed_bytes(seed).unwrap(); | |||
There was a problem hiding this comment.
Unrelated to this PR, but why don't we take [u8; WALLET_KEYS_SEED_LEN]? Bindings?
There was a problem hiding this comment.
Yes, bindings unfortunately can't handle raw arrays. We could eventually consider exposing an alternative method based on the uniffi feature.
| original_node.sync_wallets().unwrap(); | ||
| assert_eq!( | ||
| original_node.list_balances().spendable_onchain_balance_sats, | ||
| premine_amount_sat * 2 |
There was a problem hiding this comment.
Can't quite follow this. Is the above a self-send? Or is there a second wallet somewhere that isn't immediately obvious to me?
There was a problem hiding this comment.
Can't quite follow this. Is the above a self-send? Or is there a second wallet somewhere that isn't immediately obvious to me?
There indeed is a second wallet, namely the one in our bitcoind instance. As all mining rewards accrue there, we distribute funds by sending them from this wallet to the LDK Node wallet via the send_to_address RPC command.
|
CI failure is unrelated (MSRV violation to be fixed by #398) |
tnull
force-pushed
the
2024-11-onchain-recovery-test
branch
from
38c60de to
31ec815
Compare
We add a test that makes sure a completely new node is able to recover any previously-confirmed on-chain funds from the seed only.
tnull
force-pushed
the
2024-11-onchain-recovery-test
branch
from
31ec815 to
c17c995
Compare
|
Squashed commits without further changes. CI failure is yet another MSRV violation (i.e. unrelated). |
We add a test we recover on-chain funds from a given seed after the initial sync.
This extends the test coverage that would have caught #383.