Add electrum feature flag #558
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Electrum brings a dependency on
aws-lc-sys
which is causing lots of issues cross-compiling a project using ldk-node for many target platforms.This introduces an electrum feature flag and makes it a default feature as to not change the current default behavior but allows an ldk-node user to use
default-features = false
if they are not using electrum and do not wish to take the extra unnecessary dependencies.