Skip to content

routing: remove second chance logic #6891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joostjager
Copy link
Contributor

@joostjager joostjager commented Sep 6, 2022

Implemented to show the change set.

Fixes #6883

@joostjager joostjager marked this pull request as draft September 6, 2022 09:08
@joostjager
Copy link
Contributor Author

joostjager commented Sep 6, 2022

The unit test TestSendPaymentPrivateEdgeUpdateFeeExceedsLimit is failing because of the change. It's interesting though, because it isn't easy to make the test pass. Without 2nd chance logic, the failure-generating node and its incoming peer are penalized, which also blocks other routes coming in through that peer, but going out through a different channel.

The first thought may be "let's penalize the outgoing pair", because that's the channel for which the fee was incorrect. This however doesn't account for the scenario where the inbound node forwards an incorrect htlc amount and should be penalized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pathfinding "second chance" logic
1 participant