Skip to content

Support embedding root certificates. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2018
Merged

Conversation

rnburn
Copy link
Contributor

@rnburn rnburn commented Apr 12, 2018

  • Adds support to embed a default root certificates file at build time.
  • Supports specifying the root certificates via the tracer's configuration.

These features will be used to make a portable plugin that can work in environments where gRPC hasn't been installed and won't require fiddling with the GRPC_DEFAULT_SSL_ROOTS_FILE_PATH environmental variable.

@rnburn rnburn requested a review from jmacd April 13, 2018 16:03
@rnburn
Copy link
Contributor Author

rnburn commented Apr 13, 2018

Note: The bazel build fails regularly because it runs out of memory on the CI machine; it's not because it's broken.

@rnburn rnburn merged commit 42ed110 into lightstep:master Apr 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants