Use ruzstd to decompress bytecodes in Wasm
#2421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ma2bd
approved these changes
Aug 29, 2024
I thought that we could run the end-to-end tests (or at least some of them) using the web extension. That should cover the case of decompressing the bytecodes to run them 🤔 |
afck
approved these changes
Aug 29, 2024
It was incorrectly named `CompressionError`.
Allow decompressing bytecodes when running in `wasm32-unknown-unknown`.
jvff
force-pushed
the
enable-bytecode-decompression-for-web
branch
from
c44f9e6 to
672c0bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Bytecode compression was recently introduced (#2382). However, this means that the bytecode must be decompressed after it has been loaded from storage. Currently, decompression uses the
zstdcrate, which uses the Zstandard library installed on the system. Unfortunately, that library is not available in Wasm.Proposal
Use
ruzstdto decompress the bytecode in Wasm. Compression is not supported byruzstd, so bytecodes can't be published, but at least they can be decompressed so that they can executed.Test Plan
I commented out parts of the code to make it always decompress using
ruzstd, and ran the end-to-end tests manually to confirm they pass (because they publish and use bytecodes).Release Plan
Nothing is needed, because this only affects Wasm targets, for which we haven't released anything yet.
Links
Closes #2413