Restructure the composed store adaptors #2637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathieuDutSik
force-pushed
the
name_of_a_store
branch
from
8b38f3b to
8de66e6
Compare
ma2bd
changed the title
ma2bd
reviewed
Oct 18, 2024
| }; | ||
| let config = DynamoDbStoreConfig { | ||
| inner_config, | ||
| cache_size: common_config.cache_size, |
There was a problem hiding this comment.
The cache_size belongs to a LruCacheConfig.
There was a problem hiding this comment.
So compared to this PR, my idea was to replace DynamoDbStoreConfig by LruCacheConfig<DynamoDbStoreConfig> and rename DynamoDbStoreInternalConfig into DynamoDbStoreConfig.
There was a problem hiding this comment.
I understand. Indeed this PR does not implement that idea. However, that can be done next.
Thus the next step would be to remove the "Internal" attribute to the RockDb, ScyllaDb, DynamoDb and others. And they could then be exposed to users so that users could run, e.g. with ScyllaDb with cache or without.
But I think this can be done in a subsequent work.
MathieuDutSik
force-pushed
the
name_of_a_store
branch
from
8de66e6 to
f5f4c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We have the
Journaling,ValueSplitting,LruCachingandMeteredStorebut the potential is not fully exploited with a relatively large quantity of boilerplate code.Proposal
The following was done:
get_name()function is introduced to theAdminKeyValueStore. Unfortunately, it was not possible to have a&'static strsince we want to have composed types and so composed names.get_name()allows removing all theKeyValueStoreMetricsstatic variables and instead having a global store that contains theKeyValueStoreMeytrics.AdminKeyValueStoretrait function.AdminKeyValueStoreis added to all the Adaptor.LruCachingthis requires the introduction of theLruSplittingConfigthat contains the configurations in a nested way.CommonStoreConfigis split with thecache_sizebeing removed from it.pub storeare systematically changed intostorein the adaptors.Possible criticism of the design:
JournalingKeyValueStore. The rust difficulty was in thetype Keys = K::Keyssince this requires a nested key type and I think it was a little too complicated at this time.KeyValueStoreMetricswere previously as&'static LazyLock<KeyValueStoreMetrics>. Now they are asArc<KeyValueStoreMetrics>.LruSplittingError. But those would be pure boilerplate since for LRU, there is no additional error occurring.Test Plan
CI. Nothing should be affected by the refactoring.
Release Plan
Not relevant.
Links
None.