[DO NOT MERGE] DAT-20361 GitHub Secrets Migration #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace manual AWS Secrets Manager retrieval with the aws-actions/aws-secretsmanager-get-secrets action. Update all workflows to reference secrets from vault outputs instead of repository secrets. This improves maintainability and centralizes secret management.
jandroav
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates multiple GitHub Actions workflows to enhance security and centralize secret management by integrating AWS Secrets Manager. The changes replace hardcoded GitHub secrets with dynamically retrieved secrets from AWS Secrets Manager and add steps to configure AWS credentials for vault access. Below is a summary of the most important changes grouped by theme.
Integration with AWS Secrets Manager:
build-extension-jar.yml,codeql.yml,ephemeral-cloud-infra.yml,extension-attach-artifact-release.yml,extension-release-prepare.yml, andextension-release-published.yml. These steps ensure secrets are dynamically fetched and securely managed. [1] [2] [3] [4] [5] [6]Replacement of Hardcoded Secrets:
LIQUIBOT_PAT_GPM_ACCESS,GPG_SECRET,GPG_PASSPHRASE) with outputs from the AWS Secrets Manager retrieval step in all workflows. This improves security by avoiding direct exposure of secrets in workflow files. [1] [2] [3] [4] [5]Permissions Updates:
id-token: writepermissions to workflows (codeql.yml,extension-attach-artifact-release.yml,extension-release-prepare.yml) to support AWS OIDC role assumption for secure access to AWS Secrets Manager. [1] [2] [3]Environment Variable Updates:
SPACELIFT_API_KEY_ENDPOINT,SPACELIFT_API_KEY_ID, andSPACELIFT_API_KEY_SECRETfor ephemeral cloud infrastructure management. [1] [2]Workflow-Specific Enhancements:
extension-release-published.ymlto replace secrets for Sonatype Nexus staging with AWS Secrets Manager outputs, ensuring consistency in secret management across all workflows.