Implement support for hibernate timestamp columns with timezone

[philipp-kleber-avelios]

Since version 5 or 6, Hibernate started adding the with time zone suffix to columns of certain types.
This PR aims to correctly transfer the with time zone suffix from Hibernate to the corresponding Liquibase format with timezone.

[MalloD12]

@philipp-kleber-avelios,

I think it would be nice to at least add some basic unit test for this. Would you mind doing it?

Thanks,
Daniel.

[philipp-kleber-avelios]

@MalloD12,

Thank you for the feedback, I added a unit test and actually fixed a bug I noticed.
Let me know if this needs any further changes, thanks!

[MalloD12]

LGTM

Thank you for adding a test for it and finding a bug.

A comment not related to this PR. I was thinking it would be nice to use Lombok in this extension. It would be useful to make a bit less verbose all the entity classes. I'll create a a separate ticket for it.

Again, thank you for your contributions.

Daniel.

[MalloD12]

BTW, just to let you know, I created this enhancement #735 I mentioned I was going to create.

Thanks,
Daniel.

[siddharthapd]

Hello guys, seems like this is breaking for oracle to have columndefinition as it is automatically converting TIMESTAMP WITH TIME ZONE to TIMESTAMP WITH timezone

And liquibase execution with oracle 19c is failing
Reason: liquibase.exception.DatabaseException: ORA-02000: missing TIME keyword

https://docs.oracle.com/error-help/db/ora-02000/

[siddharthapd]

Seems like the issue is occuring due to this

liquibase-hibernate/src/main/java/liquibase/ext/hibernate/snapshot/ColumnSnapshotGenerator.java

Line 202 in 3e6cd8a

if (hibernateType.toLowerCase().endsWith(SQL_TIMEZONE_SUFFIX)) {

// If hibernateType ends with 'with time zone' we need to add the corresponding
        // 'with timezone' suffix to the Liquibase type.
        if (hibernateType.toLowerCase().endsWith(SQL_TIMEZONE_SUFFIX)) {
            typeName += (" " + LIQUIBASE_TIMEZONE_SUFFIX);
        }

[MalloD12]

@siddharthapd, would you mind opening a new issue for that Oracle behavior that was broken with this PR? Then, our team can prioritize it. You are also more than welcome to submit a PR if you are keen to do it.

Thanks,
Daniel.

[siddharthapd]

trying to understand the need for this. If you look at postgres we can simply use timestamptz or timestamp with time zoneand then database will auto convert it as timestamp with time zone. Not so sure which dialect timestamp with timezone will be used for. Oracle seems to be failing. To me its best we identify this case by case basis and leave it as vanilla as we can.

[siddharthapd]

@siddharthapd, would you mind opening a new issue for that Oracle behavior that was broken with this PR? Then, our team can prioritize it. You are also more than welcome to submit a PR if you are keen to do it.

Thanks, Daniel.

I will open new issue.