Skip to content

Dev UI still predicts a borrowing fee in recovery mode #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
danielattilasimon opened this issue Feb 18, 2021 · 4 comments · Fixed by #304
Closed

Dev UI still predicts a borrowing fee in recovery mode #300

danielattilasimon opened this issue Feb 18, 2021 · 4 comments · Fixed by #304
Labels
bug Something isn't working middleware released

Comments

@danielattilasimon
Copy link
Collaborator

The borrowing fee is waived during recovery mode. Dev UI should know this, and shouldn't show a fee (or should show 0%). It's also calculating collateral ratio incorrectly during recovery mode.
@danielattilasimon danielattilasimon added bug Something isn't working frontend labels Feb 18, 2021
@danielattilasimon
Copy link
Collaborator Author

Actually, this is probably something we should fix in the SDK, i.e. Fees.borrowingRate() should just return zero during recovery mode.

danielattilasimon added a commit that referenced this issue Feb 19, 2021
@danielattilasimon
fix!: correct borrowing rate in recovery mode
818e699 
BREAKING CHANGE: `fees` has been moved from `LiquityStoreBaseState`
to `LiquityStoreDerivedState`.

Most users won't need to make a code change. However, care should
be taken to upgrade both SDK packages at the same time, to ensure
compatibility.

Fixes #300.
@danielattilasimon danielattilasimon mentioned this issue Feb 19, 2021
Merged
danielattilasimon added a commit that referenced this issue Feb 19, 2021
@danielattilasimon
fix!: correct borrowing rate in recovery mode
fb1242a 
BREAKING CHANGE: `fees` has been moved from `LiquityStoreBaseState`
to `LiquityStoreDerivedState`.

Most users won't need to make a code change. However, care should
be taken to upgrade both SDK packages at the same time, to ensure
compatibility.

Fixes #300.
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎉 This issue has been resolved in version @liquity/lib-base-v2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

🎉 This issue has been resolved in version @liquity/lib-ethers-v2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

🎉 This issue has been resolved in version @liquity/lib-react-v1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

nomean42 pushed a commit to nomean42/liquity-dev that referenced this issue Nov 27, 2022
@danielattilasimon
fix!: correct borrowing rate in recovery mode
aae39c4 
BREAKING CHANGE: `fees` has been moved from `LiquityStoreBaseState`
to `LiquityStoreDerivedState`.

Most users won't need to make a code change. However, care should
be taken to upgrade both SDK packages at the same time, to ensure
compatibility.

Fixes liquity#300.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working middleware released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: correct borrowing rate in recovery mode liquity/dev
1 participant
@danielattilasimon