-
Notifications
You must be signed in to change notification settings - Fork 134
Create platform-dependent locks #657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
it seems like you haven't added any nanpa changeset files to this PR. if this pull request includes changes to code, make sure to add a changeset, by writing a file to
refer to the manpage for more information. |
0cdd352
to
47b222e
Compare
I think the idea is generally good, maybe would be nice to run another benchmark on our new (and concrete) implementation here. |
9965a36
to
627d841
Compare
627d841
to
3428117
Compare
Nice. Even though there isn’t a significant gain at the moment, it’s good to transition to the safer locks. |
4c6f9db
to
883913a
Compare
👍 Haven't noticed any perf degradation with our new measurements 📐 |
Addresses lock-related concepts like: