Skip to content

playback: improve dvr playback error handling #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 28, 2023
Merged

playback: improve dvr playback error handling #1897

merged 3 commits into from
Sep 28, 2023

Conversation

gioelecerati
Copy link
Member

@gioelecerati gioelecerati commented Sep 27, 2023 •
edited
Loading

…ning recording

What does this pull request do? Explain your changes. (required)

  • Updating the playback endpoint to return the dvrPlayback url only if available
  • We're returning two separate error messages if recording is disabled for streams or if the recording is not available so that the player UI or the clipping UI can display a proper message
  • We're omitting the url field in this case so that the player won't show the clipping icon
  • Moving the getRunningSession method to the session controller

Specific updates (required)

How did you test each of these updates (required)

Does this pull request close any open issues?

Screenshots (optional)

Checklist

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 28, 2023 4:35pm

@gioelecerati gioelecerati marked this pull request as ready for review September 27, 2023 18:05
@gioelecerati gioelecerati requested a review from a team as a code owner September 27, 2023 18:05
0xcadams
0xcadams approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@0xcadams 0xcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@victorges victorges changed the title playback: return message if recording is not enable or there's no run… playback: improve dvr playback error handling Sep 27, 2023
victorges
victorges approved these changes Sep 27, 2023
View reviewed changes
@gioelecerati gioelecerati merged commit cac9026 into master Sep 28, 2023
@gioelecerati gioelecerati deleted the gio/playback/running-recording branch September 28, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victorges victorges victorges approved these changes

@0xcadams 0xcadams 0xcadams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gioelecerati @victorges @0xcadams