Return VOD thumbs VTT URL when available #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leszko
reviewed
Nov 2, 2023
| method: "HEAD", | ||
| timeout: 5 * 1000, | ||
| }; | ||
| let resp = await fetchWithTimeout(vttUrl, params); |
There was a problem hiding this comment.
Why do you need to make this HTTP call here? Can't you just return vttUrl?
There was a problem hiding this comment.
Because the vtt will not always be present, it's not switched on for all users yet.
There was a problem hiding this comment.
Tidied this up now to check the returned files on the asset
mjh1
force-pushed
the
mh/vod-thumb-url
branch
from
7447523 to
9b87d5a
Compare
mjh1
force-pushed
the
mh/vod-thumb-url
branch
from
9b87d5a to
6781b39
Compare
leszko
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.