Skip to content

Add quality param for livestreams #1994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

leszko
Copy link
Contributor

@leszko leszko commented Dec 14, 2023

No description provided.

Copy link

vercel bot commented Dec 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
livepeer-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 14, 2023 9:29am

@emranemran emranemran marked this pull request as ready for review December 14, 2023 15:56
@emranemran emranemran requested a review from a team as a code owner December 14, 2023 15:56
@emranemran emranemran requested a review from victorges December 14, 2023 15:57
Copy link
Member

@victorges victorges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -53,6 +53,10 @@ components:
fpsDen:
type: integer
minimum: 1
quality:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we can just merge the ffmpeg-profile and profile now?

@victorges victorges merged commit d7927fe into master Dec 14, 2023
@victorges victorges deleted the rafal/add-quality-to-stream-profile branch December 14, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants