Stream pull startup improvements #2084
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| await triggerCatalystPullStart(stream, getHLSPlaybackUrl(ingest, stream)); | ||
| if (!stream.isActive) { | ||
| const ingest = await getIngestBase(req); | ||
| // TODO run in background |
There was a problem hiding this comment.
@thomshutt @victorges not sure if it's worth it but maybe we should run the manifest call in the background in case the stream becomes active whilst we're still waiting for a response there..
There was a problem hiding this comment.
Good idea. Can we also wait for other states besides Active? I think that as long as we're confident it's in a state that'll become active (e.g Pending) then that's probably okay
There was a problem hiding this comment.
Ah no, just seen that the 'pending' label you see in studio dashboard comes after the stream is active so that doesn't help.
There was a problem hiding this comment.
yeah pending is just "active but waiting for stream health data"
| @@ -1093,11 +1093,22 @@ app.put( | |||
| } | |||
| } | |||
|
|
|||
| const ingest = await getIngestBase(req); | |||
| await triggerCatalystPullStart(stream, getHLSPlaybackUrl(ingest, stream)); | |||
| if (!stream.isActive) { | |||
There was a problem hiding this comment.
Might need some logic in case the stream was just nuked above due to pull source changing. This isActive will certainly be true since it was fetched before the nuke above
There was a problem hiding this comment.
Ah yeah hadn't fully realised the significance, good catch
No description provided.