Mark UTF-8 offsets extension as deprecated #132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kadir çetinkaya <[email protected]>
| @@ -134,6 +134,10 @@ index). This was added to support integration with indexes outside clangd. | |||
| ## UTF-8 offsets | |||
| {:.v9} | |||
|
|
|||
| > [!WARNING] | |||
There was a problem hiding this comment.
What is the expected rendering of this [!WARNING]? It looks like it's intended to be some sort of markup, but in a local test of the rendering, I just see the literal characters "[!WARNING]".
There was a problem hiding this comment.
i.e. it looks like this:
There was a problem hiding this comment.
It's a GFM extension (Basic writing and formatting syntax - GitHub Docs), and should be rendered as follows:
I haven't tested this locally. Maybe Jekyll doesn't support this extension?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once llvm/llvm-project#142903 is merged and a new version of clangd is released, the utf8 offsets extension will be deprecated. This PR updates the documentation to mark this extension as deprecated.