[CIR][CIRGen] Implement CIRGenModule::shouldEmitFunction #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the usual copy-paste-modify from CodeGen, though I changed all the variable names to conform to our new style. All these functions should be pulled out as common helpers when we're upstream.
smeenai
commented
Oct 16, 2024
| return true; | ||
| namespace { | ||
| // TODO(cir): This should be a common helper shared with CodeGen. | ||
| struct FunctionIsDirectlyRecursive |
There was a problem hiding this comment.
| // decl that, because of the asm attribute or the other decl being a builtin, | ||
| // ends up pointing to itself. | ||
| // TODO(cir): This should be a common helper shared with CodeGen. | ||
| bool CIRGenModule::isTriviallyRecursive(const FunctionDecl *func) { |
There was a problem hiding this comment.
| } | ||
|
|
||
| // TODO(cir): This should be a common helper shared with CodeGen. | ||
| bool CIRGenModule::shouldEmitFunction(GlobalDecl globalDecl) { |
There was a problem hiding this comment.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This is the usual copy-paste-modify from CodeGen, though I changed all the variable names to conform to our new style. All these functions should be pulled out as common helpers when we're upstream.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This is the usual copy-paste-modify from CodeGen, though I changed all the variable names to conform to our new style. All these functions should be pulled out as common helpers when we're upstream.
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This is the usual copy-paste-modify from CodeGen, though I changed all the variable names to conform to our new style. All these functions should be pulled out as common helpers when we're upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the usual copy-paste-modify from CodeGen, though I changed all
the variable names to conform to our new style. All these functions
should be pulled out as common helpers when we're upstream.