Skip to content

[SPIRV] Allow __spirv_SpecConstant in Vulkan shaders #143543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 17, 2025
Merged

[SPIRV] Allow __spirv_SpecConstant in Vulkan shaders #143543

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4489dac
[SPIRV] Allow __spirv_SpecConstant in Vulkan shaders
s-perron Jun 10, 2025
2380271
Fix up the test.
s-perron Jun 17, 2025
447570e
Merge branch 'main' into spec-const-builtin
s-perron Jun 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions llvm/lib/Target/SPIRV/SPIRVBuiltins.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,6 +674,8 @@ defm : DemangledNativeBuiltin<"ndrange_3D", OpenCL_std, Enqueue, 1, 3, OpBuildND

// Spec constant builtin records:
defm : DemangledNativeBuiltin<"__spirv_SpecConstant", OpenCL_std, SpecConstant, 2, 2, OpSpecConstant>;
defm : DemangledNativeBuiltin<"__spirv_SpecConstant", GLSL_std_450,
SpecConstant, 2, 2, OpSpecConstant>;
defm : DemangledNativeBuiltin<"__spirv_SpecConstantComposite", OpenCL_std, SpecConstant, 1, 0, OpSpecConstantComposite>;

// Async Copy and Prefetch builtin records:
Expand Down
73 changes: 73 additions & 0 deletions llvm/test/CodeGen/SPIRV/constant/spec-constant.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,73 @@
; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv1.6-unknown-vulkan1.3-compute %s -o - | FileCheck %s
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv1.6-unknown-vulkan1.3-compute %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}

; CHECK-DAG: OpDecorate [[bool_const:%[0-9]+]] SpecId 1
; CHECK-DAG: OpDecorate [[short_const:%[0-9]+]] SpecId 2
; CHECK-DAG: OpDecorate [[int_const:%[0-9]+]] SpecId 3
; CHECK-DAG: OpDecorate [[long_const:%[0-9]+]] SpecId 4
; CHECK-DAG: OpDecorate [[float_const:%[0-9]+]] SpecId 8
; CHECK-DAG: OpDecorate [[double_const:%[0-9]+]] SpecId 9
; CHECK-DAG: OpDecorate [[enum_const:%[0-9]+]] SpecId 10

; CHECK-DAG: [[bool_const]] = OpSpecConstantTrue {{%[0-9]+}}
; CHECK-DAG: [[short_const]] = OpSpecConstant {{%[0-9]+}} 4
; CHECK-DAG: [[int_const]] = OpSpecConstant {{%[0-9]+}} 5
; CHECK-DAG: [[long_const]] = OpSpecConstant {{%[0-9]+}} 8
; CHECK-DAG: [[float_const]] = OpSpecConstant {{%[0-9]+}} 1112014848
; CHECK-DAG: [[double_const]] = OpSpecConstant {{%[0-9]+}} 0 1079574528
; CHECK-DAG: [[enum_const]] = OpSpecConstant {{%[0-9]+}} 30

@_ZL10bool_const = internal addrspace(10) global i32 0, align 4
@_ZL11short_const = internal addrspace(10) global i16 0, align 2
@_ZL9int_const = internal addrspace(10) global i32 0, align 4
@_ZL10long_const = internal addrspace(10) global i64 0, align 8
@_ZL11float_const = internal addrspace(10) global float 0.000000e+00, align 4
@_ZL12double_const = internal addrspace(10) global double 0.000000e+00, align 8
@_ZL10enum_const = internal addrspace(10) global i32 0, align 4

; Function Attrs: mustprogress nofree noinline norecurse nosync nounwind willreturn memory(readwrite, argmem: none, inaccessiblemem: none)
define void @main() local_unnamed_addr #0 {
entry:
; CHECK: [[b:%[0-9]+]] = OpSelect {{%[0-9]+}} [[bool_const]]
; CHECK: OpStore {{%[0-9]+}} [[b]]
%0 = tail call spir_func i1 @_Z20__spirv_SpecConstantib(i32 1, i1 true)
%storedv.i.i = zext i1 %0 to i32
store i32 %storedv.i.i, ptr addrspace(10) @_ZL10bool_const, align 4

; CHECK: OpStore {{%[0-9]+}} [[short_const]]
%2 = tail call spir_func i16 @_Z20__spirv_SpecConstantis(i32 2, i16 4)
store i16 %2, ptr addrspace(10) @_ZL11short_const, align 2

; CHECK: OpStore {{%[0-9]+}} [[int_const]]
%4 = tail call spir_func i32 @_Z20__spirv_SpecConstantii(i32 3, i32 5)
store i32 %4, ptr addrspace(10) @_ZL9int_const, align 4


; CHECK: OpStore {{%[0-9]+}} [[long_const]]
%6 = tail call spir_func i64 @_Z20__spirv_SpecConstantix(i32 4, i64 8)
store i64 %6, ptr addrspace(10) @_ZL10long_const, align 8

; CHECK: OpStore {{%[0-9]+}} [[float_const]]
%14 = tail call reassoc nnan ninf nsz arcp afn spir_func float @_Z20__spirv_SpecConstantif(i32 8, float 5.000000e+01)
store float %14, ptr addrspace(10) @_ZL11float_const, align 4

; CHECK: OpStore {{%[0-9]+}} [[double_const]]
%16 = tail call reassoc nnan ninf nsz arcp afn spir_func double @_Z20__spirv_SpecConstantid(i32 9, double 1.000000e+02)
store double %16, ptr addrspace(10) @_ZL12double_const, align 8

; CHECK: OpStore {{%[0-9]+}} [[enum_const]]
%18 = tail call spir_func i32 @_Z20__spirv_SpecConstantii(i32 10, i32 30)
store i32 %18, ptr addrspace(10) @_ZL10enum_const, align 4
ret void
}


declare i1 @_Z20__spirv_SpecConstantib(i32, i1)
declare i8 @_Z20__spirv_SpecConstantia(i32, i8)
declare i16 @_Z20__spirv_SpecConstantis(i32, i16)
declare i32 @_Z20__spirv_SpecConstantii(i32, i32)
declare i64 @_Z20__spirv_SpecConstantix(i32, i64)
declare float @_Z20__spirv_SpecConstantif(i32, float)
declare double @_Z20__spirv_SpecConstantid(i32, double)

attributes #0 = { "hlsl.numthreads"="1,1,1" "hlsl.shader"="compute" }
Loading