[clang][modules] NFCI: Pragma diagnostic mappings: write/read FileID instead of SourceLocation
#87427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of SourceLocation For pragma diagnostic mappings, we always write/read `SourceLocation` with offset 0. This is equivalent to just writing a `FileID`, which is exactly what this patch starts doing. Originally reviewed here: https://reviews.llvm.org/D137213
jansvoboda11
commented
Apr 2, 2024
Comment on lines
+6627
to
+6628
| // FIXME: Remove this once we don't need the side-effects. | ||
| (void)SourceMgr.getSLocEntryOrNull(FID); |
There was a problem hiding this comment.
This will be removed in a follow-up commit, to keep this one a true NFC. (Described in more detail in https://reviews.llvm.org/D137213.)
Bigcheese
approved these changes
Apr 3, 2024
jansvoboda11
added a commit
to swiftlang/llvm-project
that referenced
this pull request
Apr 3, 2024
…` instead of `SourceLocation` (llvm#87427) For pragma diagnostic mappings, we always write/read `SourceLocation` with offset 0. This is equivalent to just writing a `FileID`, which is exactly what this patch starts doing. Originally reviewed here: https://reviews.llvm.org/D137213 (cherry picked from commit c925c16)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For pragma diagnostic mappings, we always write/read
SourceLocationwith offset 0. This is equivalent to just writing aFileID, which is exactly what this patch starts doing.Originally reviewed here: https://reviews.llvm.org/D137213