-
Notifications
You must be signed in to change notification settings - Fork 2
Feat(exporter): Add new files for device tokens #2056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
92fe8fc
to
2abb545
Compare
2abb545
to
71e805d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change the commit scope. It should be design-tokens
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please add e2e visual tests to check nothing breaks. And please change the commit scope.
Also, please let Jirka know what we cannot move to the Device collection now (because of the map/object conflict). |
I am sorry, but the naming does not make sense to me. Why Wouldn't be better to use |
fd0b804
to
15a2a9d
Compare
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/14865092804/artifacts/3071853827 |
This is based on the usage in Figma, where you choose Appearance. ![]() We came up with this name, because it is best for designers and ok for us. In spirit-web you won't even know the directory, because as you can see, it is exported from @tokens too. So you will still use just |
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/14881176429/artifacts/3077321234 |
15a2a9d
to
43dfd18
Compare
43dfd18
to
cf85c0b
Compare
It was discussed in the office, and we decided to keep it named |
Description
Additional context
Issue reference
Form | Radius | New design-tokens structure