Feat: Enable gradients in components #DS-1887 #2062
+175
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
curdaj
commented
May 12, 2025
There was a problem hiding this comment.
Hardcoded for demo - will be removed
curdaj
commented
May 12, 2025
There was a problem hiding this comment.
Hardcoded for demo - will be removed
curdaj
commented
May 12, 2025
There was a problem hiding this comment.
Hardcoded for demo - will be removed
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/14970798900/artifacts/3105458963 |
|
Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/14971122819/artifacts/3105539236 |
curdaj
requested review from
literat,
pavelklibani,
katerinarehorkova,
vmilersky,
dlouhak,
a team,
adamkudrna and
crishpeen
as code owners
curdaj
force-pushed
the
feat/ds-1887-enable-gradients-in-components
branch
from
6b85d9d to
e0c759b
Compare
crishpeen
approved these changes
May 13, 2025
curdaj
force-pushed
the
feat/ds-1887-enable-gradients-in-components
branch
from
4a40679 to
e0d08b5
Compare
curdaj
force-pushed
the
feat/ds-1887-enable-gradients-in-components
branch
from
e0d08b5 to
7e2562e
Compare
crishpeen
approved these changes
May 14, 2025
dlouhak
approved these changes
May 14, 2025
Comment on lines
103
to
105
| [dictionary-color]: https://github.com/lmc-eu/spirit-design-system/blob/main/docs/DICTIONARIES.md#color | ||
| [dictionary-gradient]: https://github.com/lmc-eu/spirit-design-system/blob/main/docs/DICTIONARIES.md#gradient | ||
| [dictionary-border-properities]: https://github.com/lmc-eu/spirit-design-system/blob/main/docs/DICTIONARIES.md#border-properties |
| <Box padding="space-800" backgroundGradient="secondary"> | ||
| Secondary Background Gradient | ||
| </Box> | ||
| <Box padding="space-800" backgroundGradient={{ mobile: 'primary', tablet: 'secondary', desktop: 'secondary' }}> |
There was a problem hiding this comment.
Can we omit the desktop value if it is the same?
Suggested change
| <Box padding="space-800" backgroundGradient={{ mobile: 'primary', tablet: 'secondary', desktop: 'secondary' }}> | |
| <Box padding="space-800" backgroundGradient={{ mobile: 'primary', tablet: 'secondary' }}> |
There was a problem hiding this comment.
Or there is a typo and it should be there:
Suggested change
| <Box padding="space-800" backgroundGradient={{ mobile: 'primary', tablet: 'secondary', desktop: 'secondary' }}> | |
| <Box padding="space-800" backgroundGradient={{ mobile: 'primary', tablet: 'secondary', desktop: 'primary' }}> |
?
| <div class="docs-Stack docs-Stack--start"> | ||
|
|
||
| <p>For demo purposes, the boxes have custom padding.</p> | ||
| <div class="bg-gradient-primary p-800">Primary Background Gradient</div> |
There was a problem hiding this comment.
Non-related to this PR: p-<space-token> works, but m-<space-token> not? Why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
design-tokensfrom this PRDescription
Additional context
Issue reference