Feat(web-twig): Introduce sizes for Select, TextArea, and TextField #DS-1904
#2070
+411
−144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eld` #DS-1904 New sizes introduced according to our Size Dictionary: - `<ComponentName>--small` - `<ComponentName>--medium` (default) - `<ComponentName>--large`
adamkudrna
requested review from
literat,
crishpeen,
pavelklibani,
katerinarehorkova,
vmilersky,
dlouhak and
a team
as code owners
✅ Deploy Preview for spirit-design-system-storybook canceled.
|
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dlouhak
approved these changes
May 14, 2025
| @@ -1,6 +1,6 @@ | |||
| # TextFieldBase | |||
|
|
|||
| This is Twig implementation of the abstract component TextFieldBase for the purposes of the form components [TextField][textfield] and [TextArea][textarea]. | |||
| This is Twig implementation of the abstract component TextFieldBase for the purposes of the form components [TextField][textfield] and [TextFieldBase][textarea]. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New sizes introduced according to our Size Dictionary:
<ComponentName>--small<ComponentName>--medium(default)<ComponentName>--largeDescription
This is a follow-up of #2057.
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1689