Skip to content

add 'T: Send' to Send/Sync impls. #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021
Merged

add 'T: Send' to Send/Sync impls. #10

merged 1 commit into from
Jan 22, 2021

Conversation

JOE1994
Copy link
Contributor

@JOE1994 JOE1994 commented Jan 22, 2021

This PR fixes #9.

The Sync impl needs T: Send, but doesn't need T: Sync
since QueueSender<T> merely sends T to other threads without providing/applying concurrent access to T.
The Send impls need T: Send bound.

Thank you for reviewing this PR 👍

Copy link
Owner

@longshorej longshorej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'll release this weekend.

@longshorej longshorej merged commit 079ef99 into longshorej:master Jan 22, 2021
@JOE1994
Copy link
Contributor Author

JOE1994 commented Jan 24, 2021

Just a reminder to publish a new release to crates.io :)

@longshorej
Copy link
Owner

oh thanks - here's 0.4.0: https://crates.io/crates/conqueue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QueueSender's Send trait and Sync trait should have bounds
2 participants