Change for XDG complicance

[goranmoomin]

Fixes #1317 :-)

[goranmoomin]

My python skills are super rusty(I used python about ~4 years ago) so, you can fix it to be more 'pythonic'!

[goranmoomin]

@lra Updated commit to be more structured, added a test for XDG config (but isn't extensively testing as the code relies on the existence of a file in disk).

[goranmoomin]

@lra May I kindly ask you to review my PR? I would be very thankful if XDG landed in mackup; It's one of the five apps in my computer that doesn't follow XDG compliance.

Is there is anything that is blocking from merging?

[josh1703658784]

@lra is there any interest in merging this? Does more work need done? I'd be more than happy to help get this feature in.

[lra]

Sure! I just need to protected time to get my head around it ;)

[ya2s]

PR duplicates(#632).
It looks to need XDG_CUSTOM_APPS_DIR not only MACKUP_XDG_CONFIG_FILE

[goranmoomin]

@yamatsum Oops, Why did I not realize that! I should also have changed that... Maybe I'll try to resolve the conflicts, fix that problem and make a new PR tomorrow or the day after that.

[ya2s]

@pcr910303 I think your PR is great!
The only thing I was worried about was the file name.
I would recommend the following.

# Mackup config file; for XDG users
XDG_MACKUP_CONFIG_FILE = 'mackup.cfg'
# Directory that can contains user defined app configs; for XDG users
XDG_CUSTOM_APPS_DIR = 'mackup'

[goranmoomin]

OK, I'm working on this.

So I didn't want to have nested directories in $XDG_CONFIG_HOME/mackup, I wanted both user defined custom app configuration files and the mackup config file there. I just decided to make the config file name config.cfg, and when you load custom app configuration, you just ignore the file config.cfg.

Would this be fine?

Or... should I just revert to using a directory? 😢

[ya2s]

@pcr910303 Thank you for a great job!
I can't judge whether the specification to implement without nesting in $XDG_CONFIG_HOME/mackup is good or not.
But if the file name is config.cfg, it becomes config.config.
So I think mackup.cfg is better.

[ya2s]

If MACKUP_XDG_CONFIG_FILE does not exist, but xdg_cfg_dir does exist, is that okay?

[goranmoomin]

I guess that would force using the default config?

[goranmoomin]

Sorry for the late reply. I'm pretty busy, I think I won't be able to touch this PR for a while (probably until mid-June), but I just updated the PR to change it to mackup.cfg. I originally didn't use that because it will block making customization to mackup, but I'm not sure about that.

[ya2s]

@lra If you don't have any problems, can you merge?

[lra]

I started reviewing it, and was stopped, I can't blindly merge and break everyone's install, it's not as simple as this is a chicken/egg problem, the mackup config is impacting all other configs and must be loaded before anything else, but if it's in a place that depends on a config value, it won't work.

If there was a test to check this, it would be easier to review.

So I need more time to make sure this does not break, sorry.

Also I'd like to respect #632 and see if there is a way to merge both.

[goranmoomin]

Yeah, this PR is not really ready as @lra said. I'll try to make it ready, but it won't work in it's current state.

[goranmoomin]

Ok, I'm sorry about abandoning this PR, but I clean-installed macOS Big Sur on my machine and I'm not using Mackup anymore (not that it's not useful, but I lost my Mackup backup so... 🤦🏻‍♀️), so I don't think I'll have enough time to continue this PR . Maybe someone might continue this, but I'm closing this for now.