Skip to content

fedekunze/1575-1574 fix gov txs endpoint #1577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 15, 2018
Merged

Conversation

fedekunze
Copy link
Contributor

@fedekunze fedekunze commented Nov 14, 2018

Closes #1575 and closes #1574

Description:

Related: We can only query one tag at a time on /txs cosmos/cosmos-sdk#2819

cc: @faboweb

❤️ Thank you!


  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer

@fedekunze fedekunze changed the title WIP: fedekunze/1575-fix tag on txs search endpoint fedekunze/1575-1574 fix gov txs endpoint Nov 14, 2018
@codecov
Copy link

codecov bot commented Nov 14, 2018

Codecov Report

Merging #1577 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1577      +/-   ##
===========================================
- Coverage    96.61%   96.61%   -0.01%     
===========================================
  Files          100      100              
  Lines         1950     1949       -1     
  Branches        95       95              
===========================================
- Hits          1884     1883       -1     
  Misses          56       56              
  Partials        10       10
Impacted Files Coverage Δ
app/src/renderer/connectors/lcdClient.js 97.43% <ø> (ø) ⬆️
app/src/renderer/connectors/lcdClientMock.js 99.16% <100%> (-0.01%) ⬇️

@NodeGuy NodeGuy merged commit 5e84284 into develop Nov 15, 2018
@NodeGuy NodeGuy deleted the fedekunze/1575-fix-gov-txs branch November 15, 2018 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error: parse error near equal node.getGovernanceTxs is not a function
2 participants