Skip to content

Add camera image orientation param #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

jasiex01
Copy link
Contributor

@jasiex01 jasiex01 commented Aug 8, 2023

Overview

Author: Jan Hernas

Issue

Issue link (if present): -
Issue description: I have the OAK camera installed on my robot upside down (rotated 180 degrees). The depthai api gives a couple of options for rotating the image. All I did was output them to a ROS parameter and enabled the user to set a parameter that will rotate the image if necessary.
Related PRs -

Changes

ROS distro: Humble
List of changes:
-Add a map from string to CameraImageOrientation
-Add a parameter for camera image orientation and set the image orientation based on this parameter both in color camera and mono camera

Testing

Hardware used: OAK D-W, UpBoard 4000
Depthai library version: 2.22.0

Visuals from testing

Add screenshots/gifs/videos from RVIZ or other visualizers demonstrating the effect of the changes when applicable.
Screenshot from 2023-08-08 11-35-09

Copy link
Collaborator

@Serafadam Serafadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jasiex01, thanks for the PR! I've tested it and it works as expected, one thing I would change is parameter name from i_camera_img_orientation to i_sensor_img_orientation to avoid parameter naming confusion.

@jasiex01
Copy link
Contributor Author

Changed the parameter name

@jasiex01 jasiex01 requested a review from Serafadam August 10, 2023 20:27
Copy link
Collaborator

@Serafadam Serafadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Serafadam Serafadam merged commit f1c0656 into luxonis:humble Aug 11, 2023
@jasiex01 jasiex01 deleted the camera_orientation_param branch August 11, 2023 12:34
@jasiex01 jasiex01 restored the camera_orientation_param branch August 11, 2023 12:34
@jasiex01 jasiex01 deleted the camera_orientation_param branch August 11, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants