Skip to content

Wrong argument name in QMP scriptlet #1523

Closed
@bensmrs

Description

@bensmrs

When I implemented the QMP scriptlet, I initially used the name stage for the argument. In the doc you wrote, @stgraber, you used hook_name. When I wrote the function checks, I read the documentation and enforced the hook_name argument name. That’s where it gets nasty: the scriptlet expects stage but the check expects hook_name. Should I rename everything to stage or hook_name?

Metadata

Metadata

Assignees

Labels

EasyGood for new contributors

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions