Skip to content

TestArchitectureFirmwarePairs() fails on ppc64le/s390x #1863

Closed
@ganto

Description

@ganto

Is there an existing issue for this?

  • There is no existing issue for this bug

Is this happening on an up to date version of Incus?

  • This is happening on a supported version of Incus

Incus system details

Issue happens when building Incus for Fedora 40/41 from https://github.com/ganto/copr-lxc4/blob/master/incus/incus.spec via Fedora COPR build service.

Build log

Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.8mduoD
+ umask 022
+ cd /builddir/build/BUILD
+ cd incus-6.11
+ export GOPATH=/builddir/build/BUILDROOT/incus-6.11-0.1.fc40.ppc64le//usr/share/gocode:/usr/share/gocode
+ GOPATH=/builddir/build/BUILDROOT/incus-6.11-0.1.fc40.ppc64le//usr/share/gocode:/usr/share/gocode
+ export 'CGO_LDFLAGS_ALLOW=(-Wl,-wrap,pthread_create)|(-Wl,-z,now)'
+ CGO_LDFLAGS_ALLOW='(-Wl,-wrap,pthread_create)|(-Wl,-z,now)'
+ GO_LDFLAGS=' -X github.com/lxc/incus/version=6.11'
+ GO_TEST_FLAGS='-buildmode pie -compiler gc -v -tags libsqlite3'
+ GO_TEST_EXT_LD_FLAGS='-Wl,-z,relro -Wl,--as-needed  -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes  '
+ go-rpm-integration check -i github.com/lxc/incus -b /builddir/build/BUILD/incus-6.11/_build/bin -s /builddir/build/BUILD/incus-6.11/_build -V 6.11-0.1.fc40 -p /builddir/build/BUILDROOT/incus-6.11-0.1.fc40.ppc64le -g /usr/share/gocode -r '.*example.*' -v -t github.com/lxc/incus/test -d github.com/lxc/incus/cmd/lxc-to-incus
Testing    in: /builddir/build/BUILD/incus-6.11/_build/src
         PATH: /builddir/build/BUILD/incus-6.11/_build/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin
       GOPATH: /builddir/build/BUILD/incus-6.11/_build:/builddir/build/BUILDROOT/incus-6.11-0.1.fc40.ppc64le//usr/share/gocode:/usr/share/gocode:/usr/share/gocode
  GO111MODULE: off
      command: go test -buildmode pie -compiler gc -v -tags libsqlite3 -ldflags " -X github.com/lxc/incus/version=6.11 -extldflags '-Wl,-z,relro -Wl,--as-needed  -Wl,-z,pack-relative-relocs -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1  -Wl,--build-id=sha1 -specs=/usr/lib/rpm/redhat/redhat-package-notes  '"
      testing: github.com/lxc/incus
[...]
github.com/lxc/incus/internal/server/instance/drivers/edk2
=== RUN   TestGetEdk2Path
--- PASS: TestGetEdk2Path (0.00s)
=== RUN   TestArchitectureFirmwarePairs
    driver_edk2_test.go:83: []
--- FAIL: TestArchitectureFirmwarePairs (0.00s)
FAIL
exit status 1
FAIL	github.com/lxc/incus/internal/server/instance/drivers/edk2	0.006s

Current behavior

Incus 6.11 introduced (#1726) a new test TestArchitectureFirmwarePairs. This test fails on the Fedora COPR builds for the ppc64le and s390x architectures. I guess the reason is that these architectures don't support secure boot or even VM instances as they have no firmware images defined in architectureInstallations.

Expected behavior

The tests should not run on architectures that are not supported by the code that is tested.

Steps to reproduce

Should be possible to reproduce by running go test on an PPC64, S390 or any other non amd64/aarch64 host.

Metadata

Metadata

Assignees

Labels

EasyGood for new contributors

Type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions