incusd/network/bridge: Fix deletion of tunnels and dummy devices #1698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stgraber
reviewed
Feb 25, 2025
|
So the tests failing bring up a good point. If the user passes a gretap, vxlan or dummy device through It would probably be a good idea to go over the interfaces in |
montag451
force-pushed
the
fix-bridge-deletion
branch
2 times, most recently
from
77e83f1 to
4a3bd2f
Compare
montag451
force-pushed
the
fix-bridge-deletion
branch
from
4a3bd2f to
3badc18
Compare
The previous code relied purely on the name of the device to decide if a device should be deleted which was not correct and could result in the deletion of unwanted devices. The new code ensures that the device is part of the bridge and that its kind is correct before deleting it. Signed-off-by: montag451 <[email protected]>
montag451
force-pushed
the
fix-bridge-deletion
branch
from
3badc18 to
2c146c0
Compare
stgraber
approved these changes
Feb 28, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Mar 3, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [lxc/incus](https://github.com/lxc/incus) | patch | `v6.10.0` -> `v6.10.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>lxc/incus (lxc/incus)</summary> ### [`v6.10.1`](https://github.com/lxc/incus/releases/tag/v6.10.1) [Compare Source](lxc/incus@v6.10.0...v6.10.1) ### Announcement This is a small bugfix release on top of the main Incus 6.10 release. For Incus 6.10, please see: https://discuss.linuxcontainers.org/t/incus-6-10-has-been-released/23077 #### What's Changed - incusd/network/bridge: Fix deletion of tunnels and dummy devices by [@​montag451](https://github.com/montag451) in lxc/incus#1698 - Translations update from Hosted Weblate by [@​weblate](https://github.com/weblate) in lxc/incus#1710 - Provide the RBD keeyring to QEMU by [@​stgraber](https://github.com/stgraber) in lxc/incus#1709 - incusd/storage/ceph: Re-introduce keyring parsing by [@​stgraber](https://github.com/stgraber) in lxc/incus#1716 - Move IOMMU handling under configuration option by [@​stgraber](https://github.com/stgraber) in lxc/incus#1715 **Full Changelog**: lxc/incus@v6.10.0...v6.10.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xODIuNCIsInVwZGF0ZWRJblZlciI6IjM5LjE4Mi40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a previous PR (#1627) I forgot to update one path in the code.